feat: Failover Version table for Active-Active domains #1052
+296
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adhitya Mamallan <[email protected]>
adhityamamallan
force-pushed
the
new-failover-version
branch
from
9498dcf to
d075320
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds an expandable failover version table for Active-Active domains, displaying failover versions per cluster attribute. The implementation moves the failover version rendering logic from a dedicated component into the metadata table configuration files, and introduces a new component specifically for rendering Active-Active domain failover versions in a table format.
Key Changes:
- Replaced simple text rendering with an interactive table component for Active-Active domains
- Consolidated failover version rendering logic into config files using
createElement - Added expandable table with "Show all" functionality when entries exceed 4 items
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| domain-page-metadata-failover-version.tsx | Removed entire component - logic moved to config |
| domain-page-metadata-failover-version.test.tsx | Removed tests for deleted component |
| domain-page-metadata-failover-version-active-active.types.ts | Added type definition for failover version table entries |
| domain-page-metadata-failover-version-active-active.tsx | New component rendering expandable table of failover versions |
| domain-page-metadata-failover-version-active-active.styles.ts | Added styling and table overrides for the new component |
| domain-page-metadata-failover-version-active-active.constants.ts | Defined truncation threshold constant |
| domain-page-metadata-failover-version-active-active.test.tsx | Comprehensive tests for the new table component |
| domain-page-metadata-table.config.ts | Updated to conditionally render new component for Active-Active domains |
| domain-page-metadata-extended-table.config.ts | Updated to conditionally render new component for Active-Active domains |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...version-active-active/__tests__/domain-page-metadata-failover-version-active-active.test.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Adhitya Mamallan <[email protected]>
Assem-Uber
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Added unit tests + ran locally.
Fewer than 4 cluster attributes:
More than 4 cluster attributes:
In the legacy metadata table: